Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lodash version for fixing security vulnerability #13289

Merged
merged 2 commits into from May 10, 2021

Conversation

trinangkur
Copy link
Contributor

@trinangkur trinangkur commented May 10, 2021

Q                       A
Fixed Issues? No
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link No
Any Dependency Changes? Yes
License MIT

While doing an audit in our production we saw high vulnerability issues(command injection) related to babel. Looking further into the issue we found that lodash which is getting used in babel latest version is outdated and hence cause those vulnerabilities. Lodash has already fixed these issues and hence babel can also move to the latest version of lodash which is 4.17.21. Posting few links below to have a better understanding for everyone.

GHSA-35jh-r3h4-6jhm

https://snyk.io/vuln/SNYK-JS-LODASH-1040724

@babel-bot
Copy link
Collaborator

babel-bot commented May 10, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45953/

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04c8311:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this won't have any effect on your system: the updated package.json file is not part of any published package; this is just an internal devDependency.

Also, we don't use _.template internally so this doesn't even affect our own build process.

@nicolo-ribaudo
Copy link
Member

Can you run yarn && yarn dedupe and commit the updated lockfile?

@trinangkur
Copy link
Contributor Author

trinangkur commented May 10, 2021

Updated yarn.lock files. please merge so that we can get rid of vulnerability check issues.

@merceyz
Copy link
Contributor

merceyz commented May 10, 2021

please merge so that we can get rid of vulnerability check issues.

The package.json you've modified isn't published anywhere, like @nicolo-ribaudo said in #13289 (review) this has no impact on your system. Even if it was published semver allows for this to be fixed without any change in this repo and this repo is already using lodash@4.17.21.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️ PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants