Parse for await (async of ...)
#13244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45770/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cc7e470:
|
JLHwung
reviewed
May 1, 2021
nicolo-ribaudo
added
the
PR: Bug Fix 🐛
JLHwung
reviewed
May 1, 2021
packages/babel-parser/test/fixtures/core/categorized/for-async-of-dot/input.js
Outdated
Show resolved
Hide resolved
|
Is there any particular place I should be putting these parser tests? I wasn't sure if I should put them in |
Zalathar
force-pushed
the
async-arrow-lookahead
branch
from
2479882
to
3890721
Compare
|
@Zalathar The The |
Zalathar
force-pushed
the
async-arrow-lookahead
branch
from
3890721
to
cc7e470
Compare
nicolo-ribaudo
changed the title
for await (async of by adding lookahead to unary async arrow parsingfor await (async of ...)
This was referenced May 18, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the parser to correctly parse
for await (async of []);by implementing the suggestion given by @JLHwung in #13235 (comment).When the expression parser sees
async of, it will peek ahead for a=character before it commits to parsing an async arrow function.On its own this would also cause
for (async of []);to parse, which is forbidden, so we also add explicit code to theforparser to detect and reject for-of statements that begin withasync of.