Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runFixtureTestsWithoutExactASTMatch in parser test runner #13227

Merged
merged 2 commits into from Apr 29, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 29, 2021

Q                       A
License MIT

This PR introduces a small refactor over Babel parser fixture test runner. It extracts runFixtureTestsWithoutExactASTMatch so we can run the test routine to different Babel parser options.

Also fixed the issue that estree-throw will overwrite the fixtures when process.env.OVERWRITE is ture-ish.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Apr 29, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45694/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 064d1f4:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo changed the title introduce runFixtureTestsWithoutExactASTMatch in fixture test runner Add runFixtureTestsWithoutExactASTMatch in parser test runner Apr 29, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 0f2a1a8 into babel:main Apr 29, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the tweak-parser-fixture-runner branch April 29, 2021 16:42
@nicolo-ribaudo
Copy link
Member

I edited the title a bit to respect GH's ui commit title max length.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants