Support parsing Flow's Optional Indexed Access Types #13224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45632/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 59e4312:
|
gkz
force-pushed
the
flow-optional-indexed-access
branch
from
48ea34a
to
693092b
Compare
JLHwung
reviewed
Apr 27, 2021
gkz
force-pushed
the
flow-optional-indexed-access
branch
from
693092b
to
bdf2b54
Compare
JLHwung
reviewed
Apr 27, 2021
gkz
force-pushed
the
flow-optional-indexed-access
branch
from
bdf2b54
to
59e4312
Compare
nicolo-ribaudo
added
the
PR: New Feature 🚀
JLHwung
approved these changes
Apr 27, 2021
existentialism
approved these changes
Apr 27, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 28, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stacked on #13053 (which is not in
main, but in branchfeat-7.14.0/parser-updates, so I'm targeting that branch).Optional Indexed Access (e.g.
T?.['foo']) is like optional chaining but for indexed access.This PR also fixes a small issue with IndexedAccessType type definitions, by adding
aliases: ["Flow", "FlowType"]