Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private brand checks to shippedProposals #13176

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

They are enabled by default in Chrome 91.

The first commit is from #13172, please review that PR first.

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Brand Check for Private Fields labels Apr 19, 2021
@nicolo-ribaudo nicolo-ribaudo added this to the v7.14.0 milestone Apr 19, 2021
@nicolo-ribaudo nicolo-ribaudo changed the title Allow compiling #foo in obj without compiling private fields Add private brand checks to shippedProposals Apr 19, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9f3277b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 19, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45502/

@nicolo-ribaudo nicolo-ribaudo merged commit 098518c into babel:feat-7.14.0/preset-env Apr 21, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the shipped-proposal-private-in branch April 21, 2021 16:03
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Brand Check for Private Fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants