New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add private brand checks to shippedProposals
#13176
Merged
nicolo-ribaudo
merged 6 commits into
babel:feat-7.14.0/preset-env
from
nicolo-ribaudo:shipped-proposal-private-in
Apr 21, 2021
Merged
Add private brand checks to shippedProposals
#13176
nicolo-ribaudo
merged 6 commits into
babel:feat-7.14.0/preset-env
from
nicolo-ribaudo:shipped-proposal-private-in
Apr 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
A type of pull request used for our changelog categories
Spec: Brand Check for Private Fields
labels
Apr 19, 2021
nicolo-ribaudo
changed the title
Allow compiling
Add private brand checks to Apr 19, 2021
#foo in obj
without compiling private fieldsshippedProposals
5 tasks
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9f3277b:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45502/ |
nicolo-ribaudo
force-pushed
the
feat-7.14.0/preset-env
branch
from
April 20, 2021 21:39
838211b
to
d7d910a
Compare
nicolo-ribaudo
force-pushed
the
shipped-proposal-private-in
branch
from
April 21, 2021 13:48
c10da05
to
a8fa345
Compare
JLHwung
reviewed
Apr 21, 2021
JLHwung
approved these changes
Apr 21, 2021
nicolo-ribaudo
force-pushed
the
feat-7.14.0/preset-env
branch
from
April 21, 2021 13:56
6e9c515
to
8e5ff36
Compare
nicolo-ribaudo
force-pushed
the
shipped-proposal-private-in
branch
from
April 21, 2021 13:56
65d74f6
to
9f3277b
Compare
jridgewell
approved these changes
Apr 21, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 28, 2021
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Jul 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: New Feature 🚀
A type of pull request used for our changelog categories
Spec: Brand Check for Private Fields
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are enabled by default in Chrome 91.
The first commit is from #13172, please review that PR first.