Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links in eslint-parser README #13155

Merged
merged 2 commits into from Apr 14, 2021
Merged

Update links in eslint-parser README #13155

merged 2 commits into from Apr 14, 2021

Conversation

codyatwork
Copy link
Contributor

Q                       A
Fixed Issues? None
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No
Documentation PR Link N/A
Any Dependency Changes? No
License MIT

Updated some outdated links to the Slack invite and eslint.org in the eslint-parser README.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 14, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 78dc0f2:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung added area: eslint PR: Docs 📝 A type of pull request used for our changelog categories labels Apr 14, 2021
kaicataldo
kaicataldo requested changes Apr 14, 2021
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Can we update the ESLint chat link as well, since they've moved over to Discord?

eslint/babel-eslint-parser/README.md Outdated Show resolved Hide resolved
@codyatwork @kaicataldo
[skip ci] Update ESLint chat link
78dc0f2 
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
kaicataldo
kaicataldo approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@nicolo-ribaudo nicolo-ribaudo merged commit 54e088b into babel:main Apr 14, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codyatwork @JLHwung @kaicataldo @nicolo-ribaudo