New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use FunctionParent on visiting var scope #13152
refactor: use FunctionParent on visiting var scope #13152
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45192/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ce9853a:
|
@@ -19,7 +19,7 @@ const visitor = { | |||
if (state.kind === "let") path.skip(); | |||
}, | |||
|
|||
Function(path: NodePath) { | |||
FunctionParent(path: NodePath) { | |||
path.skip(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might actually be a bugfix?
let x = async do {
class A {
static {
var a = 2;
}
}
}
since we use hoistVariables
for asycn do expressions, I'd expect var
here to be hoisted before this PR (but I didn't test it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be a bugfix when we mark StaticBlock
as FunctionParent
, but I tend to land it in another PR with new tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok 👍
E2E Vue error is unrelated, it's also failing in other PRs. |
Based on #13151 (comment), we should use
FunctionParent
when we intend to visit those AST nodes starting a newvar
scope. This PR does not have observable behaviour changes since currentlyFunction
equals toFunctionParent
.