Update to Yarn 3

[nicolo-ribaudo]

Q	A
Any Dependency Changes?	Yes, Yarn (committed dev dependency)
License	MIT

Yarn 3 isn't stable yet, but I want to verify that it doesn't introduce any unexpected regression in our workflow.

It currently breaks our release tool, but it's a known breaking change.

What works so far:

• yarn install (also with the condition: plugin)
• yarn install works on CI (feat: make enableImmutableInstalls default to true on ci yarnpkg/berry#2530)
• yarn release-tool version
• yarn release-tool publish

You can see the breaking changes list at https://github.com/yarnpkg/berry/blob/master/CHANGELOG.md#breaking-changes. We are affected by:

• Node.js 10 has been dropped
• Yarn runs with --immutable by default on CI
  There are workarounds/changes for both of them.

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48746/

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 62c08b9:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

[merceyz]

Would you be willing to change this PR to use the CLI from yarnpkg/berry#2161 and enable PnP for the build step again? I updated the PR over the weekend and added tests based on your comments from last time and fixed some issues that caused it to crash when running yarn gulp in this repo, it looks like it works but would be nice to have the CI agree.

[nicolo-ribaudo]

Ok, sure!

[nicolo-ribaudo]

When using PnP the generated @babel/standalone bundle is broken, but it might be caused by something else (maybe Rollup).

[merceyz]

Yeah I saw that, looked into the bundle but nothing stood out, I see the methods are missing but not sure why

[merceyz]

These two imports are merged into one https://github.com/facebook/regenerator/blob/dbbddd9bd8c099ed1cdfcecdd077b8b4e7f43042/packages/transform/src/leap.js#L10-L11 so it's trying to get inherits from ./util which doesn't exist

[merceyz]

Got some time to look into it and it looks like a bug on our end, I'll fix it

[nicolo-ribaudo]

Oh thanks! Let me know when I have to update this PR.

[nicolo-ribaudo]

Yarn 3 has been released! I removed the commit to test yarnpkg/berry#2161 since that PR has been deferred to a later version. I'll update a new branch PR if we'll have to test ESM support before that it's merged.

[nicolo-ribaudo]

@arcanis Was the --skip-builds option removed? It's not mentioned in the changelog 🤔

[arcanis]

It got replaced by --mode=skip-build, I'll add it to the changelog 👍

[nicolo-ribaudo]

The CI failure looks related

[larixer]

@nicolo-ribaudo I'm not sure that its related, but why did you do:

Have you seen that it fails?

[arcanis]

Running the following locally seems to work for me - could it just be that your trunk has legit breaking changes that would break using a version of @babel/types at the same time as the trunk one? I don't see other e2e-breaking-pr tests running so I can't compare 🤔

rm -rf /tmp/jest
git clone --depth=1 https://github.com/facebook/jest /tmp/jest 
cd /tmp/jest
node -e "
  var pkg = require('./package.json');
  pkg.resolutions || (pkg.resolutions = {});
  pkg.resolutions['@types/babel__traverse/@babel/types'] = 'latest';
  fs.writeFileSync('./package.json', JSON.stringify(pkg, null, 2));
"
yarn install
yarn build

[nicolo-ribaudo]

Yeah, I think that "related" is more something on our side uncovered by an innocuous change in Yarn.

@larixer I don't remember, I'll revert it back 😅

[nicolo-ribaudo]

Ok, it looks like I used npm to install verdaccio because Yarn 3 throws:

+ yarn global add verdaccio-memory@~9.7.2
Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)

[merceyz]

We have a compat layer that is supposed to handle that 🤔

[nicolo-ribaudo]

Q: Is this for corepack?

[merceyz]

Yes, when corepack is enabled running yarn will launch yarn@3.0.0 which will check yarnPath and use that binary if it doesn't match the one corepack launched

[merceyz]

CI is passing but @yarnpkg/plugin-constraints should be updated as well

[nicolo-ribaudo]

Greeeen 🥳

[nicolo-ribaudo]

After merging this I'll do something like yarnpkg/berry#3431

[hzoo]

nice work, verifying is much easier than testing ci..

[merceyz]

The issue in #13140 (comment) has been fixed and the ESM PR has been updated