New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babel-parser: Add new internal ESLint rule to consistent error messages #13130
babel-parser: Add new internal ESLint rule to consistent error messages #13130
Conversation
Oh, this PR includes huge diffs.. But almost diff are updating snapshots. |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45136/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 207f2fb:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note for reviewers: I suggest reviewing the first 3 commits, the others are snapshot changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I rebased |
9571427
to
13d1014
Compare
e847f90
to
e9aed2c
Compare
Thanks! I had to reword the commit message a bit so that it doesn't get cropped by GH's ui. |
I have been concerned about the inconsistent in the format of error messages. However, tools such as Prettier use error messages as their interface, and It wasn't able to fixed.
With the introduction of error codes in 7.14, it is now easier to fix error messages.
So I created an Internal ESLint rule to enforce the format of error messages.
What do you think about this?