Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class static blocks to preset-env's shippedProposals #13114

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 7, 2021

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

cc @rbuckton (just fyi) this means that Babel users can now use it with @babel/preset-env without needing to manually install a separate plugin.

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: preset-env Spec: Class Static Block labels Apr 7, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 7, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45121/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6481085:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added this to the v7.14.0 milestone Apr 7, 2021
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Apr 8, 2021
@JLHwung
Copy link
Contributor

JLHwung commented Apr 9, 2021

We should also add private brand checks to shippedProposals: https://chromestatus.com/feature/5006138707804160

Copy link
Member

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At what stage do we usually add to shipped?

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Apr 9, 2021

When at least one browser ships it unflagged. Chrome 91 is still in dev which is quite experimental, but it will be beta in two weeks (which I think will be more or less when we'll publish 7.14.0).

@nicolo-ribaudo nicolo-ribaudo changed the base branch from main to feat-7.14.0/preset-env April 9, 2021 17:04
@nicolo-ribaudo nicolo-ribaudo merged commit 64b3d9e into babel:feat-7.14.0/preset-env Apr 16, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the shipped-proposal-static-block branch April 16, 2021 17:46
@nicolo-ribaudo
Copy link
Member Author

Merged to feat-7.14.0/preset-env

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Needs Docs PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Class Static Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants