New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support TS 4.3 static index signature in class #13096
support TS 4.3 static index signature in class #13096
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45050/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df0a593:
|
packages/babel-parser/test/fixtures/typescript/class/index-signature/input.ts
Show resolved
Hide resolved
For the tests failure, you can run |
packages/babel-parser/test/fixtures/typescript/class/index-signature/input.ts
Show resolved
Hide resolved
packages/babel-parser/test/fixtures/typescript/class/index-signature/input.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
After that this PR is merged, would you then like to open a new PR to use the InvalidModifiersOrder
error for
class A {
readonly static foo = 2;
}
?
Currently it just throws "unexpected token" (repl).
Oh also, could you rebase this on top of https://github.com/babel/babel/tree/feat-7.14.0/parser-updates? 🙏 I'm using that branch for all the parser PRs for 7.14.0, to avoid merge conflicts when we'll merge all the PRs for the release. |
|
Reference: https://devblogs.microsoft.com/typescript/announcing-typescript-4-3-beta/#static-index-signatures
Allow: