Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile classes when spread is unsupported #13075

Merged
merged 3 commits into from Mar 31, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 30, 2021

Q                       A
Fixed Issues? Ref #12722
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

There are some firefox versions where one thing between "classes" and "spread" is supported and the other is not. This causes a compilation error.

I bumped the spread data to align them with the classes data. I also wrote a bugfix plugin, but given that the compat data are almost the same probably it's not worth the complexity.

I'm really confused about comparing supported versions (i.e. what supports what), so it's possible that this PR isn't needed and I just interpreted the data in a wrong way.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env Spec: Classes labels Mar 30, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44877/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f074690:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The PR title is backwards. You're compiling classes when you compile spread, not spread when classes.

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Mar 30, 2021

Ohh, that why I was so confused, thanks!

@nicolo-ribaudo nicolo-ribaudo changed the title Compile spread when compiling classes Compile classes when spread is unsupported Mar 30, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit d563773 into babel:main Mar 31, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the compile-spread-for-classes branch March 31, 2021 14:42
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Classes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants