New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): make sure "clone-deep-browser" code path is used on browsers #13068
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bde6698:
|
67324a5
to
84112b4
Compare
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44855/ |
@@ -41,6 +41,7 @@ | |||
"./lib/config/files/index.js": "./lib/config/files/index-browser.js", | |||
"./lib/config/resolve-targets.js": "./lib/config/resolve-targets-browser.js", | |||
"./lib/transform-file.js": "./lib/transform-file-browser.js", | |||
"./lib/transformation/util/clone-deep.js": "./lib/transformation/util/clone-deep-browser.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: nevermind, I see it now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🤦
We need to map both the lib
and the src
folder:
lib
if for people bundling@babel/core
src
is when we generate the@babel/standalone
bundle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
When using a published package, the
clone-deep
file lives underlib
instead ofsrc
.