Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parsing Flow's Indexed Access Types #13053

Merged
merged 6 commits into from Apr 7, 2021
Merged

Support parsing Flow's Indexed Access Types #13053

merged 6 commits into from Apr 7, 2021

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Mar 25, 2021 •
edited

Q                       A
Fixed Issues? Fixes #13052
Patch: Bug Fix? N?
Minor: New Feature? Y?
Tests Added + Pass? Yes
License MIT

I created the original issue as a "bug report", but it may be "feature request".

@babel-bot
Copy link
Collaborator

babel-bot commented Mar 25, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44731/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 25, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de7d234:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor optimization comment.

For reference only, here is Flow's implementation on parsing indexed access: facebook/flow@f493122

packages/babel-parser/src/plugins/flow/index.js Outdated Show resolved Hide resolved
@JLHwung JLHwung added this to the v7.14.0 milestone Mar 26, 2021
@JLHwung JLHwung added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Mar 26, 2021
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Mar 26, 2021
@sosukesuzuki sosukesuzuki mentioned this pull request Mar 30, 2021
Closed
@nicolo-ribaudo nicolo-ribaudo changed the base branch from main to feat-7.14.0/parser-updates April 7, 2021 09:15
@nicolo-ribaudo nicolo-ribaudo merged commit 7b3d94b into babel:feat-7.14.0/parser-updates Apr 7, 2021
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 7, 2021
Merged
9 tasks
nicolo-ribaudo pushed a commit that referenced this pull request Apr 9, 2021
@sosukesuzuki @nicolo-ribaudo
Support parsing Flow's Indexed Access Types (#13053)
365dcdc
nicolo-ribaudo pushed a commit that referenced this pull request Apr 13, 2021
@sosukesuzuki @nicolo-ribaudo
Support parsing Flow's Indexed Access Types (#13053)
bee2481
JLHwung pushed a commit that referenced this pull request Apr 16, 2021
@sosukesuzuki @JLHwung
Support parsing Flow's Indexed Access Types (#13053)
8af4862
JLHwung pushed a commit that referenced this pull request Apr 17, 2021
@sosukesuzuki @JLHwung
Support parsing Flow's Indexed Access Types (#13053)
62b11c6
JLHwung pushed a commit that referenced this pull request Apr 19, 2021
@sosukesuzuki @JLHwung
Support parsing Flow's Indexed Access Types (#13053)
fba45b8
nicolo-ribaudo pushed a commit that referenced this pull request Apr 20, 2021
@sosukesuzuki @nicolo-ribaudo
Support parsing Flow's Indexed Access Types (#13053)
b6ce7c3
nicolo-ribaudo pushed a commit that referenced this pull request Apr 22, 2021
@sosukesuzuki @nicolo-ribaudo
Support parsing Flow's Indexed Access Types (#13053)
5415726
nicolo-ribaudo pushed a commit that referenced this pull request Apr 23, 2021
@sosukesuzuki @nicolo-ribaudo
Support parsing Flow's Indexed Access Types (#13053)
df740d1
nicolo-ribaudo pushed a commit that referenced this pull request Apr 26, 2021
@sosukesuzuki @nicolo-ribaudo
Support parsing Flow's Indexed Access Types (#13053)
de28011
@gkz gkz mentioned this pull request Apr 27, 2021
Merged
nicolo-ribaudo pushed a commit that referenced this pull request Apr 28, 2021
@sosukesuzuki @nicolo-ribaudo
Support parsing Flow's Indexed Access Types (#13053)
f8aa32f
@ssidorchik ssidorchik mentioned this pull request May 12, 2021
Closed
1 task
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator pkg: parser pkg: types PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Milestone
v7.14.0
Development

Successfully merging this pull request may close these issues.

Support Flow's indexed access type
5 participants
@sosukesuzuki @babel-bot @existentialism @JLHwung @nicolo-ribaudo