Remove lodash from babel-compat-data #13024
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 02fbf1b:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44519/ |
| return array.reduce((flattened, value) => { | ||
| return flattened.concat(value); | ||
| }, []); | ||
| } |
There was a problem hiding this comment.
We could just bump the Node.js version requirement for building Babel to 12 (currently it's 10 I think), and avoid the polyfill.
There was a problem hiding this comment.
that will be a breaking change, wdyt about doing this for babel8?
There was a problem hiding this comment.
It's not a breaking change, it's just the minimum Node.js versions used when building Babel (it doesn't affect the code published on npm, which is subject to semver).
There was a problem hiding this comment.
Actually, the minimum Node.js version is already 12 since many scripts we use are native ES modules. We can remove the polyfill without problems.
There was a problem hiding this comment.
That's good, because I forgot to call cb in this polyfill….. 😅
nicolo-ribaudo
added
the
PR: Internal 🏠
github-actions
bot
added
the
outdated
Re: #11726