Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat data #13008

Merged
merged 4 commits into from Mar 19, 2021
Merged

Update compat data #13008

merged 4 commits into from Mar 19, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 16, 2021

Q                       A
Fixed Issues? The second step on fixing #13001
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR bumps compat-table and adds support data on the upcoming bugfix/transform-v8-spread-parameters-after-optional-chaining.

"samsung": "13",
"electron": "8.0"
},
"bugfix/transform-v8-spread-parameters-after-optional-chaining": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT bugfix/v8-spread-parameters-after-optional-chaining? I can't think of any term other transform that could follow bugfix/.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: in, not after?

@babel-bot
Copy link
Collaborator

babel-bot commented Mar 16, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44368/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d14eab4:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

"samsung": "13",
"electron": "8.0"
},
"bugfix/transform-v8-spread-parameters-after-optional-chaining": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: in, not after?

Copy link
Contributor Author

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also bump private-methods as

new class { #m() {} constructor() { null?.#m(...[], 1) } }

also throws.

Or we transpile it to

new class { #m() {} constructor() { null == null ? undefined : null.#m(...[], 1) } }

so it is still good to assume v8 84 has full support of private methods.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Mar 19, 2021

@JLHwung In that case we should only transpile the optional chain, leaving private methods as-is.

@JLHwung JLHwung merged commit 020c88e into babel:main Mar 19, 2021
@JLHwung JLHwung deleted the update-compat-data branch March 19, 2021 12:34
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: compat-table outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: compat-data PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants