New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compat data #13008
Update compat data #13008
Conversation
"samsung": "13", | ||
"electron": "8.0" | ||
}, | ||
"bugfix/transform-v8-spread-parameters-after-optional-chaining": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT bugfix/v8-spread-parameters-after-optional-chaining
? I can't think of any term other transform
that could follow bugfix/
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: in
, not after
?
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44368/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d14eab4:
|
"samsung": "13", | ||
"electron": "8.0" | ||
}, | ||
"bugfix/transform-v8-spread-parameters-after-optional-chaining": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: in
, not after
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also bump private-methods
as
new class { #m() {} constructor() { null?.#m(...[], 1) } }
also throws.
Or we transpile it to
new class { #m() {} constructor() { null == null ? undefined : null.#m(...[], 1) } }
so it is still good to assume v8 84 has full support of private methods.
@JLHwung In that case we should only transpile the optional chain, leaving private methods as-is. |
This PR bumps
compat-table
and adds support data on the upcomingbugfix/transform-v8-spread-parameters-after-optional-chaining
.