Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not throw when creating type annotation based on bigint #12971

Merged
merged 4 commits into from Mar 19, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 5, 2021

Q                       A
Fixed Issues? Closes #12965, fixes #13018
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: types labels Mar 5, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Mar 5, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44375/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5eee3af:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

} else if (type === "bigint") {
// todo: use BigInt annotation when Flow supports BigInt
// https://github.com/facebook/flow/issues/6639
return anyTypeAnnotation();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not use numberTypeAnnotation here because Math functions do not work with BigInt. Mark it as any as it is not supported in Flow.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we could consider moving away from Flow as an internal representation of types.

@JLHwung JLHwung merged commit 8596316 into babel:main Mar 19, 2021
@JLHwung JLHwung deleted the create-type-annotation-based-on-bigint branch March 19, 2021 15:44
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printing out the invalid typeof value in error thrown by createTypeAnnotationBasedOnTypeof
4 participants