New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse type imports in TSImportEqualsDeclaration #12962
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fd32324:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43681/ |
Any news on this one? 👀 Seems relatively straightforward, but there's been a couple of bug fix releases without it, so I might be missing something |
Uh sorry, maybe @sosukesuzuki or @hzoo do you have time to quickly check if the changes seem ok? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok gave a look, looks good!
I can release a patch tomorrow. |
This PR implements parsing support on type imports in TSImportEqualsDeclaration
Similar to what we did for
ImportDeclaration
, an enum propertyimportKind: "value" | "type"
will be added toTsImportEqualsDeclaration
.Note that when
importKind
is"type"
, the TSModuleReference on the RHS can not be an Identifier or a TSQualfiedName, which becomes an import alias for TypeScript, e.g. bothand
will throw "An import alias can not use 'import type'".