Fix Module not found: Error: Can't resolve 'core-js/modules/es6.array.concat.js' with compat-data@7.13.x

[luxp]

Q	A
Patch: Bug Fix?	Bugfix
Major: Breaking Change?	No
Minor: New Feature?	No
Tests Added + Pass?	Yes
Any Dependency Changes?	No
License	MIT

After upgrade the @babel/compat-data@7.13 encounted the problem below.

.babelrc

[
      '@babel/preset-env',
      {
        'targets': targets || {
          'android': '4',
          'ios': '9',
        },
        'useBuiltIns': 'entry',
        'corejs': 2,
        'modules': false,
      },
]

Usage in code

import '@babel/polyfill'

Related this pull request: https://github.com/babel/babel/pull/12850/files#r582504324

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42769/

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ecf1057:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

[nicolo-ribaudo]

I'm sorry 🤦 I missed this because the comment explaining why these were not included gave the wrong reason.

Can you delete them from packages/babel-compat-data/scripts/data/corejs2-built-in-features.js?

[nicolo-ribaudo]

NOTE: The CI / Test @babel/runtime integrations failure is unrelated (it's also failing on main).

Could you run OVERWRITE=true make test to update the fixtures? I don't think there will be any change, since those fixtures are generated by babel-plugin-polyfill-corejs2 which pulls the @babel/compat-data dependency from npm and not from the monorepo.

[nicolo-ribaudo]

Actually, adding this to resolutions in the top-level package.json would probably make the tests correctly reflect @babel/compat-data:

"babel-plugin-polyfill-corejs2/@babel/compat-data": "workspace:*"

[luxp]

Actually, adding this to resolutions in the top-level package.json would probably make the tests correctly reflect @babel/compat-data:

"babel-plugin-polyfill-corejs2/@babel/compat-data": "workspace:*"

I'm trying

[nicolo-ribaudo]

You need to run yarn to update the lockfile 🙏

[luxp]

This seems has been fixed. And tests are all passed on my local machine.

[nicolo-ribaudo]

Thanks!