New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-parser): merge input estree
options
#12891
fix(eslint-parser): merge input estree
options
#12891
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42451/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e66fbc3:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I'd label this as a [Bug fix]
, since it's an observable change in the behavior.
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
estree
options
Great , thank you . |
@babel/eslint-parser
users should be able to opt-in to theclassFeatures: boolean
In #12867 we move estree class features behind a
classFeatures: boolean
option. However it is impossible to be allowed in@babel/eslint-parser
because Babel parser does not merge plugin options. In this PR we merge user supplied estree options to the builtin estree options defaults.After this PR is shipped, you can specify
classFeatures
to enable estree class features implementation in.eslintrc.js
:cc @fisker