Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-parser): merge input estree options #12891

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 24, 2021

Q                       A
Fixed Issues? @babel/eslint-parser users should be able to opt-in to the classFeatures: boolean
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In #12867 we move estree class features behind a classFeatures: boolean option. However it is impossible to be allowed in @babel/eslint-parser because Babel parser does not merge plugin options. In this PR we merge user supplied estree options to the builtin estree options defaults.

After this PR is shipped, you can specify classFeatures to enable estree class features implementation in .eslintrc.js:

module.exports = {
  parser: "@babel/eslint-parser",
  parserOptions: {
    requireConfigFile: false,
    babelOptions: {
      parserOpts: {
        plugins: [
          ["estree", { classFeatures: true }],
          "classPrivateProperties",
          "classProperties",
        ],
      },
    },
  },
};

cc @fisker

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories area: eslint labels Feb 24, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Feb 24, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42451/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 24, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e66fbc3:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'd label this as a [Bug fix], since it's an observable change in the behavior.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories and removed PR: Polish 💅 A type of pull request used for our changelog categories labels Feb 24, 2021
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
@nicolo-ribaudo nicolo-ribaudo changed the title fix: user supplied estree option should be merged to default estree options fix(eslint-parser): merge input estree options Feb 24, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 227f881 into babel:main Feb 24, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the merge-estree-options-in-eslint-parser branch February 24, 2021 19:13
@fisker
Copy link
Contributor

fisker commented Feb 24, 2021

Great , thank you .

This was referenced Mar 5, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants