New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add es6.array.slice
in corejs2 builtins
#12870
Conversation
@@ -850,6 +850,17 @@ | |||
"samsung": "4", | |||
"electron": "0.30" | |||
}, | |||
"es6.array.slice": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42140/ |
Thanks! We use this file to generate compat data from compat-table, could you update it? |
This REPL still reporting the same error, but this change fixed my local project builds already. Is the REPL supposed to load |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eae5038:
|
The problem is that there is a cross-dependency between this repository and https://github.com/babel/babel-polyfills, so it won't be fixed in the REPL until we publish a Babel release. |
e73858d
to
500f3b5
Compare
Thanks 👍 One last thing: could you update the |
@@ -73,8 +73,8 @@ module.exports = { | |||
"es6.array.of": "Array static methods / Array.of", | |||
"es6.array.reduce": "Array methods / Array.prototype.reduce", | |||
"es6.array.reduce-right": "Array methods / Array.prototype.reduceRight", | |||
// compat-table missing babel6 mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still a valid reason? I'm seeing a few more compat-table missing babel6 mapping
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh no, we can add all of them back if they are in compat-table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, let me add them back also then
8609b74
to
de12063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm having lunch now, I'll release right after (so that CI has time to run)
Whops, try running |
out for dinner too, be back later |
@nicolo-ribaudo @eligao We found another similar error It seemed |
@clarkdo I made it a warning rather than an error in |
Thanks for the reply, actually building failed because |
Oh ok 🙃 I can work on a PR later, unless you want to work on it. |
@nicolo-ribaudo I'm OK to take it, Do you think we should add it to |
The fix should be in However, |
This polyfill es6.array.slice is present in
corejs2
but missing in thecompat-data
package.This introduces the error
Internal error in the corejs2 provider: unknown polyfill "es6.array.slice"