Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that @babel/runtime-corejs3 imports are injected #12869

Merged
merged 3 commits into from Feb 23, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 23, 2021

Q                       A
Fixed Issues? Fixes #12863
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT


function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = _getPrototypeOf(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = _getPrototypeOf(this).constructor; result = _Reflect$construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return _possibleConstructorReturn(this, result); }; }

function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !_Reflect$construct) return false; if (_Reflect$construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(_Reflect$construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug is that _Reflect$construct is not imported.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e725ee:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04eae76:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 23, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/42101/

@nicolo-ribaudo nicolo-ribaudo added i: regression PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Feb 23, 2021
@nicolo-ribaudo nicolo-ribaudo changed the title Add failing test for #12863 Ensure that @babel/runtime-corejs3 imports are injected Feb 23, 2021
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review February 23, 2021 11:46
@nicolo-ribaudo nicolo-ribaudo merged commit 115841e into babel:main Feb 23, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the regression-4 branch February 23, 2021 11:47
@aj-dev
Copy link

aj-dev commented Feb 23, 2021

@nicolo-ribaudo when can we expect a release with this fix? Thanks!

@nicolo-ribaudo
Copy link
Member Author

Soon, I am updating those packages again and I'll publish.

This was referenced Mar 15, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError: _forEachInstanceProperty is not defined
3 participants