[internal] Keep the .cjs extension when compiling source files
#12820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e6285a9:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41148/ |
nicolo-ribaudo
force-pushed
the
keep-cjs-ext
branch
from
d1619fe
to
55bf64c
Compare
nicolo-ribaudo
force-pushed
the
keep-cjs-ext
branch
from
55bf64c
to
e6285a9
Compare
nicolo-ribaudo
added this to To review
in Nicolò's ideal PR review order list
via automation
nicolo-ribaudo
moved this from To review
to Reviewed
in Nicolò's ideal PR review order list
nicolo-ribaudo
moved this from Reviewed
to To review
in Nicolò's ideal PR review order list
JLHwung
approved these changes
Feb 25, 2021
hzoo
approved these changes
Feb 25, 2021
This was referenced Mar 5, 2021
Closed
This was referenced Mar 8, 2021
Closed
Closed
Closed
This was referenced Mar 16, 2021
Closed
Merged
Closed
Closed
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #12814. With this PR, our gulp setup will transform the input files extensions as follows:
.ts->.js.d.ts->.d.ts.js->.js.cjs->.cjs.mjs->.mjsThis is needed because, when preparing our code base for the ESM switch, we need to make sure that some files (
.cjs) only contain CJS and aren't interpreted as ESM if we add"type": "module"topackage.jsonfiles.Fyi, I opened babel/gulp-babel#211 to discuss making this an option of
gulp-babel.