Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Yarn 2.4.0 #12453

Merged
merged 5 commits into from Dec 8, 2020
Merged

Use Yarn 2.4.0 #12453

merged 5 commits into from Dec 8, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 6, 2020

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Yes, Yarn
License MIT

The new Yarn version lets us remove some code from the publish plugin: nicolo-ribaudo/yarn-plugin-babel-release-tool@e56bcef

If the CRA e2e test fails, that's fixed by #12450.

@nicolo-ribaudo nicolo-ribaudo added PR: Internal 🏠 A type of pull request used for our changelog categories PR: Dependency ⬆️ labels Dec 6, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 6, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34223/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83a8bc6:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove

babel/Makefile

Lines 239 to 244 in 2ba9265

check-yarn-bug-1882:
ifneq ("$(shell grep 3155328e5 .yarn/releases/yarn-*.cjs -c)", "0")
echo "Your version of yarn is affected by https://github.com/yarnpkg/berry/issues/1882"
echo "Please run `sed -i -e "s/3155328e5/4567890e5/g" .yarn/releases/yarn-*.cjs`"
exit 1
endif
now.

@merceyz
Copy link
Contributor

merceyz commented Dec 7, 2020

We haven't merged yarnpkg/berry#2005 yet so you need to keep it for now

@nicolo-ribaudo
Copy link
Member Author

Wait, I didn't run that sed command: why it isn't failing? 🤔

@nicolo-ribaudo
Copy link
Member Author

Before the Makefile update:

➜ make check-yarn-bug-1882
echo "Your version of yarn is affected by https://github.com/yarnpkg/berry/issues/1882"
Your version of yarn is affected by https://github.com/yarnpkg/berry/issues/1882
echo "Please run `sed -i -e "s/3155328e5/4567890e5/g" .yarn/releases/yarn-*.cjs`"
Please run 
exit 1

After the Makefile update:

➜ make check-yarn-bug-1882
Your version of yarn is affected by https://github.com/yarnpkg/berry/issues/1882
Please run `sed -i -e s/3155328e5/4567890e5/g .yarn/releases/yarn-*.cjs`

(both are still exiting with 1)

@JLHwung JLHwung merged commit aca5edb into babel:main Dec 8, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the yarn-2.4 branch December 14, 2020 11:02
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️ PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants