Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new CircleCI images #12450

Merged
merged 3 commits into from Dec 9, 2020
Merged

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 5, 2020

Q                       A
Tests Added + Pass? Yes
License MIT

CRA e2e tests started failing today with this error:

Husky requires Git >=2.13.0. Got v2.11.0.

The only change I could find is that they updated Docker from 18.09.6 to 19.03.13. I'm not sure how this affected the Git version, but maybe the new images work 🤷

I already tried updating the images at #12243 and gave up due to this error, but I think I found a fix:

error while loading shared libraries: libXss.so.1: cannot open shared object file: No such file or directory

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Dec 5, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 5, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34159/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cfb817e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@nicolo-ribaudo
Copy link
Member Author

Now also Jest is failing on main, but it's also failing in their repo: https://github.com/facebook/jest/runs/1506557985

@pustovalov
Copy link
Contributor

pustovalov commented Dec 7, 2020

It was a problem inside husky:
typicode/husky#822

adding HUSKY_SKIP_INSTALL helped me

example:

executors:
  default:
    docker:
      - image: circleci/node:14.15-browsers
        environment:
          CI: true
          HUSKY_SKIP_INSTALL: 1

@nicolo-ribaudo
Copy link
Member Author

Thanks! The Husky issue has been fixed and now it's passing on main.
I'm still keeping this PR open, since Circle CI is marketing these images as the successors of the ones we are currently using.

@nicolo-ribaudo nicolo-ribaudo merged commit 0e27105 into babel:main Dec 9, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the circleci-images branch December 9, 2020 18:24
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants