Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-types update OptionalCallExpression to support ArgumentPlaceholder #12418

Merged

Conversation

zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Nov 27, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Adding support for ArgumentPlaceholder in OptionalCallExpression to align it with CallExpression.

Found this while rebasing #11578

@nicolo-ribaudo
Copy link
Member

Thanks! Could you run make build to re-generate the generated functions?

@zxbodya
Copy link
Contributor Author

zxbodya commented Nov 27, 2020

Thanks! Could you run make build to re-generate the generated functions?

sure, forgot about that when cherrypicking it

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33593/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b15a5d3:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Partial Application labels Nov 27, 2020
@nicolo-ribaudo
Copy link
Member

Ref: tc39/proposal-partial-application#35

This is not specified as valid syntax in the proposal, but we are currently accepting it and it aligns with the opinion of the proposal author.

@zxbodya
Copy link
Contributor Author

zxbodya commented Nov 27, 2020

sure, forgot about that when cherrypicking it

it looks to be not required - changes are only it generated typing files, which are not in git

@nicolo-ribaudo
Copy link
Member

Oh right, I didn't notice that it's just changing the accepted types.

@JLHwung
Copy link
Contributor

JLHwung commented Nov 30, 2020

@zxbodya Did you push the generated typings?

@zxbodya
Copy link
Contributor Author

zxbodya commented Nov 30, 2020

@zxbodya Did you push the generated typings?

it is only for files in lib folder which are generated during build, so nothing to push

@JLHwung JLHwung merged commit 2ca28d7 into babel:main Nov 30, 2020
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Dec 2, 2020
@zxbodya zxbodya deleted the babel-types-update-optional-call-expression branch December 15, 2020 17:24
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Partial Application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants