Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify isAwaitAllowed #12398

Merged
merged 1 commit into from Nov 25, 2020
Merged

refactor: simplify isAwaitAllowed #12398

merged 1 commit into from Nov 25, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 25, 2020 •
edited by gitpod-io bot

Q                       A
License MIT

Simplified parser.isAwaitAllowed a bit.

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: parser labels Nov 25, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33237/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b9a6e20:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@kaicataldo
Copy link
Member

Nice refactor 😃

@JLHwung JLHwung merged commit 89f3247 into babel:main Nov 25, 2020
@JLHwung JLHwung deleted the simplify-is-await-allowed branch November 25, 2020 18:49
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Dec 2, 2020
@JLHwung @nicolo-ribaudo
refactor: simplify isAwaitAllowed (babel#12398)
0c6e7b6
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @kaicataldo @existentialism