Avoid infinite loops in type inference logic

[nicolo-ribaudo]

Q	A
Fixed Issues?	Fixes #12388
Patch: Bug Fix?	Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

This fix is copied from

babel/packages/babel-traverse/src/path/introspection.js

Lines 363 to 369 in 8f191ea

	// Used to avoid infinite recursion in cases like
	// function f() { if (false) f(); }
	// f();
	// It also works with indirect recursion.
	const executionOrderCheckedNodes = new WeakSet();
	export function _guessExecutionStatusRelativeToDifferentFunctions(

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33103/

[nicolo-ribaudo]

@ehoogeveen Can you check if replacing the _getTypeAnnotation function in https://unpkg.com/browse/@babel/traverse@7.12.7/lib/path/inference/index.js fixes this crash on your end?

+ const typeAnnotationInferringNodes = new WeakSet();

  function _getTypeAnnotation() {
    var _inferer;

    const node = this.node;

    if (!node) {
      if (this.key === "init" && this.parentPath.isVariableDeclarator()) {
        const declar = this.parentPath.parentPath;
        const declarParent = declar.parentPath;

        if (declar.key === "left" && declarParent.isForInStatement()) {
          return t.stringTypeAnnotation();
        }

        if (declar.key === "left" && declarParent.isForOfStatement()) {
          return t.anyTypeAnnotation();
        }

        return t.voidTypeAnnotation();
      } else {
        return;
      }
    }

    if (node.typeAnnotation) {
      return node.typeAnnotation;
    }

+   if (typeAnnotationInferringNodes.has(node)) {
+     return;
+   }
+   typeAnnotationInferringNodes.add(node);
+ 
+   try {

    let inferer = inferers[node.type];

    if (inferer) {
      return inferer.call(this, node);
    }

    inferer = inferers[this.parentPath.type];

    if ((_inferer = inferer) == null ? void 0 : _inferer.validParent) {
      return this.parentPath.getTypeAnnotation();
    }
+   } finally {
+     typeAnnotationInferringNodes.delete(node);
+   }
  }

[JLHwung]

(When reviewing, please disable whitespace changes and reload.)

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6f397dc:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

[ehoogeveen]

@nicolo-ribaudo Yes, I see no more crashes after applying this change :) (in fact with this change a stack limit of 70kB is enough to minify Sortable.js)