Initialize NodePath context when using getSibling
#12387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
commented
Nov 23, 2020
| }); | ||
|
|
||
| expect(testHasScope).toBe(true); | ||
| expect(consequentHasScope).toBe(true); |
There was a problem hiding this comment.
Before this PR consequentHasScope is false.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33072/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 562b4d6:
|
existentialism
approved these changes
Nov 23, 2020
JLHwung
approved these changes
Nov 23, 2020
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Dec 2, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
pathreturned byNodePath.get()is passed back to plugins code, we must make sure to always initialize thecontext(otherwise it re-uses a possibly wrong cached contex).I'm marking this PR as
i: regressioneven if this bug was already present, because #12331 made it more common (noScope: truewas almost ignored before that PR, while after that PR it's respected).