Make sure babel parser throws exactly same recoverable errors when estree plugin is enabled #12375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When estree plugin is enabled, stringLiteral#extra.raw is not accessible. Use StringLiteral#value instead.
JLHwung
added
PR: Spec Compliance 👓
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/32931/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c962cb3:
|
nicolo-ribaudo
approved these changes
Nov 20, 2020
nicolo-ribaudo
added this to To review
in Nicolò's ideal PR review order list
via automation
existentialism
approved these changes
Dec 3, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
estreeplugin is enabledThis PR can be reviewed commits by commits.
The first commit implements matching
"errors"of AST output tofixture-test-runner, so we can test whether we still throw exactly the same recoverable error whenestreeparser plugin is enabled.The other commits are to fix the bugs detected by the new test runner.
In the future I will add more tests to estree plugin: For example, if the parsed AST does not have an
"errors"key, it should not throw either whenestreeplugin is enabled.