Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts]Set false to default value of TsTypePredicate.asserts #12352

Merged
merged 1 commit into from Nov 16, 2020
Merged

[ts]Set false to default value of TsTypePredicate.asserts #12352

merged 1 commit into from Nov 16, 2020

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Nov 12, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? N
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR has same purpose just as #12167. #12167 isn't enough for this type. So this PR sets false to default value of TSTypePredicate.asserts.

@sosukesuzuki sosukesuzuki added area: typescript PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Nov 12, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/32509/

@sosukesuzuki sosukesuzuki changed the title Set false to default value of TsTypePredicate.asserts [ts]Set false to default value of TsTypePredicate.asserts Nov 12, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e08a36b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@existentialism existentialism merged commit a4e4aed into babel:main Nov 16, 2020
@sosukesuzuki sosukesuzuki deleted the align-with-ts-estree branch November 17, 2020 02:03
@sosukesuzuki sosukesuzuki mentioned this pull request Nov 21, 2020
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sosukesuzuki @babel-bot @JLHwung @nicolo-ribaudo @existentialism