Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: inline @babel/helper-regex usage #12349

Merged
merged 1 commit into from Nov 18, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 11, 2020

Q                       A
Tests Added + Pass? Yes
Any Dependency Changes? @babel/helper-regex is not depended by any package in monorepo
License MIT

This PR inlines @babel/helper-regex to our repo. We can archive @babel/helper-regex in another PR.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 11, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/32487/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d0f1b4c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeeees less packages 🥳😆

@nicolo-ribaudo nicolo-ribaudo changed the title refactor: remove @babel/helper-regex usage refactor: inline @babel/helper-regex usage Nov 11, 2020
@nicolo-ribaudo
Copy link
Member

I update the PR title.just for the changelog, so that we can then have an "archive helper-regex" without it seem a duplicate of this one.

@JLHwung JLHwung merged commit ab5a90c into babel:main Nov 18, 2020
@JLHwung JLHwung deleted the remove-babel-helper-regex-usage branch November 18, 2020 15:07
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants