refactor: use option-validator in preset-typescript #12347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Polish 💅
JLHwung
commented
Nov 11, 2020
| @@ -29,12 +29,6 @@ export default declare((api, opts) => { | |||
| const development = !!opts.development; | |||
| const useBuiltIns = !!opts.useBuiltIns; | |||
|
|
|||
| if (typeof development !== "boolean") { | |||
There was a problem hiding this comment.
This branch is unreachable, we have cast development to boolean by double negation above.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/32474/ |
nicolo-ribaudo
approved these changes
Nov 11, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4c023d8:
|
existentialism
approved these changes
Nov 18, 2020
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Dec 2, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/preset-typescriptnow depends on@babel/helper-validator-optionThis PR is extracted from #10927. It targets to current
main.In another PR, I plan to re-introduce #10927 behind a flag (tentatively named as
BABEL_8_PRESET_OPTION_CHECK) like we did in #11172, so it is non-breaking change (not if you randomly assignBABEL_8_*env in your CI) and we can merge without holding off for a long while.