Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chokidar@2 without fsevents@1 in @babel/cli #12322

Merged
merged 1 commit into from Nov 10, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 6, 2020

Q                       A
Fixed Issues? Fixes #12320
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? https://github.com/nicolo-ribaudo/chokidar-2 / https://unpkg.com/browse/@nicolo-ribaudo/chokidar-2@2.1.8-no-fsevents/
License MIT

If fsevents is not available, chokidar should fallback to fs polling by default. Since fsevents is never going to be available now that the binaries aren't hoisted anymore, we can remove it from our deps avoiding the node-gyp error for MacOS users.

Can someone with MacOS confirm that with this PR, babel --watch still works on Node.js 6?

@nicolo-ribaudo nicolo-ribaudo added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: cli labels Nov 6, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 6, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31924/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 6, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b807c4b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo
Copy link
Member Author

The failing tests are fixed by #12323

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️People can be obsessed with warning messages from an optional dependency.

@nicolo-ribaudo
Copy link
Member Author

Yeah, chokidar was definitely the most wanted change for Babel 8 😛

@nicolo-ribaudo nicolo-ribaudo merged commit 40727ab into babel:main Nov 10, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the fsevents-warning branch November 10, 2020 08:12
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: cli PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install failing on optional dependency fsevents@1.2.7 in @babel/cli
4 participants