Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Mark ThisExpression and Super as Purish" #12307

Merged
merged 1 commit into from Nov 4, 2020
Merged

Revert "Mark ThisExpression and Super as Purish" #12307

merged 1 commit into from Nov 4, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 4, 2020 •
edited by gitpod-io bot

Reverts #12251

Fixes #12306

@nicolo-ribaudo nicolo-ribaudo added i: regression PR: Revert ↩️ A type of pull request used for our changelog categories pkg: types labels Nov 4, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31711/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1404aed:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@SoloJiang
Copy link

IMG_0156

@nicolo-ribaudo nicolo-ribaudo merged commit dd5a977 into main Nov 4, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the revert-12251-this-purish branch November 4, 2020 10:50
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Revert ↩️ A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] when ThisExpression marked as Purish, deadcode plugin will remove arrowy function plugin build result
3 participants
@nicolo-ribaudo @babel-bot @SoloJiang