New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support string assertion key in assert entries #12281
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31360/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 16ec192:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a typo! thanks!
Co-authored-by: Sosuke Suzuki <aosukeke@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol 🙃
import "foo.js" assert { "type": "json" }
(REPL)I am shocked that we don't have a test covering valid case
import "foo.js" assert { "type": "json" }
. This PR also disallows the following invalid cases: