fix: disallow import assertions in export without from #12264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31228/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c877a7a:
|
existentialism
changed the title
| ] | ||
| ], | ||
| "sourceType": "module", | ||
| "throws": "Unexpected token, expected \";\" (2:15)" |
There was a problem hiding this comment.
Wonder if we should point out a missing from in the error message given assertions? (Might be better DX)
There was a problem hiding this comment.
I think it is okay here because when from is missing
export { someExport } asserts { type: "json" }it would first throw
"someExport" is not defined
If users have already provided someExport, it is unlikely someExport could be exported from another module and thus they should consider remove the assertions.
existentialism
approved these changes
Oct 27, 2020
sosukesuzuki
added a commit
to prettier/prettier
that referenced
this pull request
Nov 6, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export { foo } assert { type: "json" };should be disallowedThis PR fixes a bug we introduced in #12249, import assertions should only be parsed when we have seen
from.