Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: babel-types: ImportDeclaration: add assertions #12263

Merged
merged 2 commits into from Oct 27, 2020
Merged

fix: babel-types: ImportDeclaration: add assertions #12263

merged 2 commits into from Oct 27, 2020

Conversation

coderaiser
Copy link
Contributor

@coderaiser coderaiser commented Oct 27, 2020

Q                       A
Fixed Issues? Fixes #12262
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

When using template.ast with code:

import json from "./foo.json" assert { type: "json" };

Resulting AST contains no assertions field. This PR fixes this.

@babel-bot
Copy link
Collaborator

babel-bot commented Oct 27, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31190/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c2918df:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
babel-repl-custom-plugin Issue #12262

@nicolo-ribaudo
Copy link
Member

Thanks! Can you also add this to export declarations? (faaebfe)

@nicolo-ribaudo nicolo-ribaudo added pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Oct 27, 2020
@coderaiser
Copy link
Contributor Author

@nicolo-ribaudo Sure, done in c2918df.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@existentialism existentialism merged commit 9eb661b into babel:main Oct 27, 2020
@existentialism
Copy link
Member

@coderaiser thanks!

@coderaiser coderaiser deleted the fix/template-ast-import-declaration-assertions branch October 27, 2020 21:04
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template.ast produces AST without assertions fields in ImportDeclaration
4 participants