Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support bigInt in numeric-separator transform #12240

Merged
merged 1 commit into from Oct 22, 2020
Merged

fix: support bigInt in numeric-separator transform #12240

merged 1 commit into from Oct 22, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 22, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? proposal-numeric-separator does not remove numeric separator in bigint 1_2n (REPL)
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

Apply the transform to BigIntLiteral same as NumericLiteral.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: BigInt Spec: Numeric Separator labels Oct 22, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/30794/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2fec753:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

nicolo-ribaudo
nicolo-ribaudo approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JLHwung JLHwung changed the title feat: support bigInt in numeric-separator transform fix: support bigInt in numeric-separator transform Oct 22, 2020
@JLHwung JLHwung merged commit 8b579a2 into babel:main Oct 22, 2020
@JLHwung JLHwung deleted the support-bigint-in-proposal-numeric-separator branch October 22, 2020 20:49
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: BigInt Spec: Numeric Separator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @existentialism @nicolo-ribaudo