Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts] Error on invalid type casts in JSX #12221

Merged
merged 2 commits into from Oct 23, 2020
Merged

[ts] Error on invalid type casts in JSX #12221

merged 2 commits into from Oct 23, 2020

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Oct 19, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #12215
Patch: Bug Fix? Y
License MIT

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels Oct 19, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be6082c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung
Copy link
Contributor

JLHwung commented Oct 19, 2020

The e2e error is not related: browserify/resolve@205b660

existentialism
existentialism commented Oct 19, 2020
View reviewed changes
packages/babel-parser/src/parser/expression.js
@@ -2057,14 +2064,6 @@ export default class ExpressionParser extends LValParser {
refExpressionErrors,
node,
);
if (canBePattern && !this.state.maybeInArrowParameters) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now moved to the flow plugin (since it doesn't apply to TypeScript)

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/30614/

@existentialism existentialism merged commit c00bb14 into main Oct 23, 2020
@existentialism existentialism deleted the issue12215 branch October 23, 2020 13:09
@sosukesuzuki sosukesuzuki mentioned this pull request Nov 4, 2020
Merged
sosukesuzuki added a commit to prettier/prettier that referenced this pull request Nov 6, 2020
@sosukesuzuki
Add tests for babel/babel#12221
f934269
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No syntax error is thrown for invalid TSTypeCastExpression at JSX expression wrapped in parentheses
4 participants
@existentialism @JLHwung @babel-bot @kaicataldo