New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse class static block #12079
Parse class static block #12079
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29367/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e53fdfd:
|
ffd03b5
to
7ae65f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 outside of a minor question around the error message
@@ -1487,3 +1492,9 @@ export type ParseSubscriptState = { | |||
maybeAsyncArrow: boolean, | |||
stop: boolean, | |||
}; | |||
|
|||
export type ParseClassMemberState = {| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL I learned about Flow's exact object types 👍🏼
Co-authored-by: Brian Ng <bng412@gmail.com>
c40f8e1
to
9e8864d
Compare
@JLHwung I'm merging this into the |
Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Brian Ng <bng412@gmail.com>
This PR implements parsing/generating support for the Stage 2 Class Static Block Proposal.
Note that current implementation is aligned to tc39/proposal-class-static-block#15.
/cc @ljharb @rbuckton