Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-proposal-function-bind): fix invalid code emitted for ::super.foo #12000

Merged
merged 2 commits into from Aug 24, 2020

Conversation

uhyo
Copy link
Contributor

@uhyo uhyo commented Aug 24, 2020

Q                       A
Fixed Issues? none
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR fixes the handling of super in plugin-proposal-function-bind.
Current implementation emits invalid code when converting ::super.foo.

example

Input

class C {
  foo() {
    ::super.bar;
    ::super.baz(123);
  }
}

Current Output

class C {
  foo() {
    super.bar.bind(super);
    super.baz.call(super, 123);
  }

}

New Output

class C {
  foo() {
    super.bar.bind(this);
    super.baz.call(this, 123);
  }

}

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27773/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 955aa09:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Function Bind labels Aug 24, 2020
@existentialism existentialism merged commit 76d571e into babel:main Aug 24, 2020
@existentialism
Copy link
Member

@uhyo thanks for the PR!

@uhyo uhyo deleted the fix-bind-super branch August 25, 2020 00:00
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Function Bind
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants