Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure import() is not transpiled in babel-core published source #11974

Merged
merged 2 commits into from Aug 20, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 17, 2020

Q                       A
Fixed Issues? Fixes #11958
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

#11879 introduced a regression: Since @babel/core is compiled with gulp-babel, which does not declare support of dynamic import, import() is transpiled in the published source: https://unpkg.com/browse/@babel/core@7.11.0/lib/config/files/import.js

This PR adds the extra caller data and also a hacky prepublish test to ensure that .mjs loading works in the published builds.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression pkg: core labels Aug 17, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27526/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 15c25e9:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung added this to the 7.11.4 milestone Aug 18, 2020
packages/babel-core/test/config-chain.js Outdated Show resolved Hide resolved
@JLHwung JLHwung merged commit 4be67fb into babel:main Aug 20, 2020
@JLHwung JLHwung deleted the fix-11958 branch August 20, 2020 17:31
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 20, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel.config.mjs not working
5 participants