Move legacy node version tests to GitHub actions #11952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27360/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c3cf71c:
|
JLHwung
force-pushed
the
test-node-6-8-on-github-actions
branch
3 times, most recently
from
6a66e97
to
de6e828
Compare
fisker
reviewed
Aug 13, 2020
JLHwung
force-pushed
the
test-node-6-8-on-github-actions
branch
from
de6e828
to
9f14d98
Compare
hzoo
approved these changes
Aug 13, 2020
JLHwung
force-pushed
the
test-node-6-8-on-github-actions
branch
from
3223832
to
c07cc06
Compare
nicolo-ribaudo
approved these changes
Aug 14, 2020
|
Awesome! |
existentialism
approved these changes
Aug 14, 2020
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves legacy node versions (6.x, 8.x) tests to GitHub versions. The new legacy version test workflow will build Babel on latest node but run unit tests on legacy node. By doing so it paves the way to bump Babel build requirements to
>= 10.13. Babel 7 still supports node 6, but to build babel project, we requires higher node versions.