Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable flowcheck on CI #11945

Merged
merged 2 commits into from Aug 10, 2020
Merged

chore: enable flowcheck on CI #11945

merged 2 commits into from Aug 10, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 10, 2020

Q                       A
Fixed Issues? CI does not bail on flow errors: https://travis-ci.com/github/babel/babel/jobs/370394437#L849
License MIT

The first commit bails on CI as expected: https://travis-ci.com/github/JLHwung/babel/jobs/370449449
The second commit fixes flow errors.

@JLHwung JLHwung added PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories labels Aug 10, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 10, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27172/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4fcf13e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung marked this pull request as ready for review August 10, 2020 19:18
@@ -226,7 +227,7 @@ export default (superClass: Class<Parser>): Class<Parser> =>
this.parseClassSuper(node);
node.body =
this.parsePlaceholder("ClassBody") ||
this.parseClassBody(!!node.superClass);
this.parseClassBody(!!node.superClass, oldStrict);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kaicataldo kaicataldo merged commit a389312 into babel:main Aug 10, 2020
@kaicataldo kaicataldo deleted the fix-failing-main branch August 10, 2020 20:57
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants