New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: push new token context when braceHashL is seen #11941
Conversation
JLHwung
commented
Aug 10, 2020
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Fixes #11926 |
Patch: Bug Fix? | Yes |
Tests Added + Pass? | Yes |
License | MIT |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d7116db:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27224/ |
@@ -0,0 +1 @@ | |||
(#{})/foo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case fails on current main
, because a token context is not pushed and both tt.braceR.updateContext
and tt.parenR.updateContext
incorrectly set this.state.exprAllowed = true
(when context.length
is 1) so /foo
is parsed as unterminated regex.