Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some @babel/traverse from deps to devDeps #11937

Merged
merged 1 commit into from Aug 10, 2020

Conversation

yukukotani
Copy link
Contributor

@yukukotani yukukotani commented Aug 9, 2020

Q                       A
Fixed Issues? No issue
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Yes
License MIT

Move some @babel/traverse which is used for only type import (like import type { NodePath } from "@babel/traverse";) from dependencies to devDependencies.

The dist won't be changed, but this PR fixes incorrect behavior of applications that refer package.json such as Skypack.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd8cf98:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27085/

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 9, 2020
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@existentialism existentialism merged commit 00b9742 into babel:main Aug 10, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants