Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not push version commit on lerna version #11936

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 8, 2020

Q                       A
License MIT

Per https://github.com/lerna/lerna/tree/master/commands/version#--no-push, if push: false is specified, lerna will not push the version commit and the tags to the remote. So when we are publishing from local, we don't have to switch the tracking branch to origin as we did before.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 8, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e959ba0:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27079/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I solved this by setting two different remotes for push and pull, but this is easier

@JLHwung JLHwung merged commit fccf31a into babel:main Aug 10, 2020
@JLHwung JLHwung deleted the do-not-push-version-commit-on-lerna-version branch August 10, 2020 11:29
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants