Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add ImportExpression visitorKeys #11932

Merged
merged 1 commit into from Aug 8, 2020
Merged

fix: add ImportExpression visitorKeys #11932

merged 1 commit into from Aug 8, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 8, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #10904
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

As a follow-up to #10828, this PR adds ImportExpression to VISITOR_KEYS.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: eslint labels Aug 8, 2020
@JLHwung JLHwung requested a review from kaicataldo August 8, 2020 12:13
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 8, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27037/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 665011e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 69c9f1e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung commented Aug 8, 2020
View reviewed changes
eslint/babel-eslint-parser/test/index.js
@@ -569,7 +569,7 @@ describe("Babel and Espree", () => {

it("Dynamic Import", () => {
parseAndAssertSame(`
const a = import('a');
const a = import(moduleName);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test example is revised so that if we do not update VISITOR_KEYS, the identifier will not be traversed and the test will fail due to mismatch AST. Note that when traversing AST we remove loc.identifierName.

@JLHwung JLHwung merged commit 48e793e into babel:main Aug 8, 2020
@JLHwung JLHwung deleted the fix-10904 branch August 8, 2020 19:44
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template string failing with Cannot read property 'range' of null
4 participants
@JLHwung @babel-bot @hzoo @kaicataldo