Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ExpressionBody should respect [In] parameter #11931

Merged
merged 1 commit into from Aug 26, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 7, 2020

Q                       A
Fixed Issues? Fixes #11202
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Aug 7, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd3da42:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 7, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27125/

@@ -2110,7 +2110,8 @@ export default class ExpressionParser extends LValParser {
this.state.inParameters = false;

if (isExpression) {
node.body = this.parseMaybeAssignAllowIn();
// https://tc39.es/ecma262/#prod-ExpressionBody
node.body = this.parseMaybeAssign();
Copy link
Contributor Author

@JLHwung JLHwung Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the [In] parameter tracking refactor, the fix is straightforward: parseMaybeAssign parses AssignmentExpression[?In], while parseMaybeAssignAllowIn parses AssignmentExpression[In].

According to the spec we should replace parseMaybeAssignAllowIn by parseMaybeAssign.

@JLHwung JLHwung merged commit 2c60595 into babel:main Aug 26, 2020
@JLHwung JLHwung deleted the fix-11202 branch August 26, 2020 17:24
fisker added a commit to prettier/prettier that referenced this pull request Sep 1, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[parser] Illegal arrow expression containing in as for lhs
4 participants