New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ExpressionBody should respect [In] parameter #11931
Conversation
JLHwung
commented
Aug 7, 2020
•
edited
edited
Q | A |
---|---|
Fixed Issues? | Fixes #11202 |
Patch: Bug Fix? | Yes |
Tests Added + Pass? | Yes |
License | MIT |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd3da42:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27125/ |
@@ -2110,7 +2110,8 @@ export default class ExpressionParser extends LValParser { | |||
this.state.inParameters = false; | |||
|
|||
if (isExpression) { | |||
node.body = this.parseMaybeAssignAllowIn(); | |||
// https://tc39.es/ecma262/#prod-ExpressionBody | |||
node.body = this.parseMaybeAssign(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the [In]
parameter tracking refactor, the fix is straightforward: parseMaybeAssign
parses AssignmentExpression[?In]
, while parseMaybeAssignAllowIn
parses AssignmentExpression[In]
.
According to the spec we should replace parseMaybeAssignAllowIn
by parseMaybeAssign
.